2787 merge vulnerability and brute force exploiter config #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija-lazoroski
force-pushed
the
2787-merge-vulnerability-and-brute-force-exploiter-config
branch
from
5a1a008
to
c8cf86d
Compare
Codecov ReportBase: 64.21% // Head: 64.19% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2796 +/- ##
===========================================
- Coverage 64.21% 64.19% -0.03%
===========================================
Files 407 407
Lines 11581 11573 -8
===========================================
- Hits 7437 7429 -8
Misses 4144 4144
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mssalvatore
requested changes
Jan 6, 2023
The separation between brute force and vulnerability exploiters was based on the use case of "vulnerability scanning", which is no longer Infection Monkey's main goal. Ultimately, users should be able to configure the order that exploiters run in. While the UI doesn't allow this at the moment, the configuration can be manipulated manually to achieve this. However, vulnerability exploiters always run before brute force exploiters. In other words, this separation reduces the configurability of the system. By merging these into a single list of exploiters, we allow the user to have total control over the order in which exploiters are run. Issue #2787 PR #2789
mssalvatore
force-pushed
the
2787-merge-vulnerability-and-brute-force-exploiter-config
branch
from
20257f5
to
3db41de
Compare
mssalvatore
approved these changes
Jan 6, 2023
mssalvatore
deleted the
2787-merge-vulnerability-and-brute-force-exploiter-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2787.
PR Checklist
Testing Checklist