-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash login password on server side with bcrypt #1139
Conversation
…vices/AuthService.js
Codecov Report
@@ Coverage Diff @@
## develop #1139 +/- ##
===========================================
- Coverage 28.71% 28.64% -0.08%
===========================================
Files 410 411 +1
Lines 12877 12892 +15
===========================================
- Hits 3698 3693 -5
- Misses 9179 9199 +20
Continue to review full report at Codecov.
|
In python, private static methods serve no purpose. Python has first-class functions; let's use them.
The default values were only really used by the test code. We can simplify the Usercreds's interface and test code by removing functionality (read: complication) we don't really need.
Fixes #969
Uses bcrypt to salt and hash the password on the server side before storing it.
PR Checklist
Testing Checklist