Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash login password on server side with bcrypt #1139

Merged
merged 29 commits into from
May 5, 2021
Merged

Hash login password on server side with bcrypt #1139

merged 29 commits into from
May 5, 2021

Commits on May 3, 2021

  1. Add functionality to hash passwords on server side

    @PrajwalM2212 @shreyamalviya
    PrajwalM2212 authored and shreyamalviya committed May 3, 2021
    Configuration menu
    Copy the full SHA
    9363cad View commit details
    Browse the repository at this point in the history

  2. Changes

    @PrajwalM2212 @shreyamalviya
    PrajwalM2212 authored and shreyamalviya committed May 3, 2021
    Configuration menu
    Copy the full SHA
    2ee6315 View commit details
    Browse the repository at this point in the history

  3. Use bcrypt for password hashing for authentication

    @shreyamalviya
    shreyamalviya committed May 3, 2021
    Configuration menu
    Copy the full SHA
    b5236d1 View commit details
    Browse the repository at this point in the history

  4. Remove unused import and repeated code in monkey_island/cc/ui/src/ser… 

    …vices/AuthService.js
    @shreyamalviya
    shreyamalviya committed May 3, 2021
    Configuration menu
    Copy the full SHA
    09a3729 View commit details
    Browse the repository at this point in the history

  5. Add bcrypt to monkey_island/Pipfile and monkey_island/Pipfile.lock

    @shreyamalviya
    shreyamalviya committed May 3, 2021
    Configuration menu
    Copy the full SHA
    b5d05a1 View commit details
    Browse the repository at this point in the history

  6. Convert hashed pwd to string before storing in server_config.json

    @shreyamalviya
    shreyamalviya committed May 3, 2021
    Configuration menu
    Copy the full SHA
    d208314 View commit details
    Browse the repository at this point in the history

  7. Split get_from_dict() into 2 functions as per usage

    @shreyamalviya
    shreyamalviya committed May 3, 2021
    Configuration menu
    Copy the full SHA
    02f3b15 View commit details
    Browse the repository at this point in the history

  8. Add CHANGELOG entry for bcrypt work

    @shreyamalviya
    shreyamalviya committed May 3, 2021
    Configuration menu
    Copy the full SHA
    9c1096d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. island: Make return values of Authenticate._authenticate() explicit

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    7684a2d View commit details
    Browse the repository at this point in the history

  2. island: Change order of methods in Authenticate to follow stepdown rule

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    83f7f04 View commit details
    Browse the repository at this point in the history

  3. island: Extract method get_credentials_from_request() from post()

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    39c274c View commit details
    Browse the repository at this point in the history

  4. island: Give _authenticate() more descriptive name and remove comment

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    a8646fc View commit details
    Browse the repository at this point in the history

  5. island: Extract method _create_access_token() from _get_credentials_f… 

    …rom_request()
    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    c7d47fe View commit details
    Browse the repository at this point in the history

  6. island: Replace private static functions in Authenticator with functions 

    In python, private static methods serve no purpose. Python has
first-class functions; let's use them.
    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    904e51a View commit details
    Browse the repository at this point in the history

  7. island: Minor formatting fix

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    060c4b0 View commit details
    Browse the repository at this point in the history

  8. island: Enable standard mode with bcrypted passwords

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    502bc3b View commit details
    Browse the repository at this point in the history

  9. Refactored test_user_creds.py to pytest from unittests

    @VakarisZ @mssalvatore
    VakarisZ authored and mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    f28cd53 View commit details
    Browse the repository at this point in the history

  10. monkey: Rename get_from...() methods in UserCreds to be more readable

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1be07a4 View commit details
    Browse the repository at this point in the history

  11. island: Add UserCreds.from_cleartext()

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    5fa08f0 View commit details
    Browse the repository at this point in the history

  12. island: Remove coupling between EnvironmentConfig and UserCreds

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    4b3b7af View commit details
    Browse the repository at this point in the history

  13. monkey: Remove coupling between Registration and UserCreds

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1aed5f3 View commit details
    Browse the repository at this point in the history

  14. island: Simplify UserCreds constructor by removing defaults 

    The default values were only really used by the test code. We can
simplify the Usercreds's interface and test code by removing
functionality (read: complication) we don't really need.
    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    d56cb5c View commit details
    Browse the repository at this point in the history

  15. island: Add tests for UserCreds.__bool__()

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    e223126 View commit details
    Browse the repository at this point in the history

  16. island: Add test for members of UserCreds

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    c4c0b72 View commit details
    Browse the repository at this point in the history

  17. island: Add constants for user and hash to UserCreds tests

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    e4dec55 View commit details
    Browse the repository at this point in the history

  18. island: Remove parameter names from UserCreds() init in tests

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    f73b048 View commit details
    Browse the repository at this point in the history

  19. island: Remove UserCreds.from_cleartext()

    @mssalvatore
    mssalvatore committed May 4, 2021
    Configuration menu
    Copy the full SHA
    0f49a2c View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. island: Move all bcrypt dependencies to password_utils

    @mssalvatore
    mssalvatore committed May 5, 2021
    Configuration menu
    Copy the full SHA
    9024a51 View commit details
    Browse the repository at this point in the history

  2. island: Add FULL_USER_CREDENTIALS to test_environment.py

    @mssalvatore
    mssalvatore committed May 5, 2021
    Configuration menu
    Copy the full SHA
    7772ea6 View commit details
    Browse the repository at this point in the history