Slm

src/components/Makefile.comp

@@ -19,7 +19,9 @@ SHARED_FLAGS=-fno-merge-constants -nostdinc -nostdlib -fno-pic -fno-pie
 #OPT= -g -fvar-tracking
 OPT= -O3
 
-CFLAGS=$(ARCH_CFLAGS) -Wall -Wextra -Wno-unused-parameter -Wno-type-limits -Wno-unused-function -fno-stack-protector -fno-omit-frame-pointer -Wno-unused-variable $(CINC) $(MUSLINC) $(OPT) $(SHARED_FLAGS)
+# This removes warnings from Ubuntu 20 (gcc 9.3), but should likely be removed by fixing the issue
+TMPFLGS := -Wno-address-of-packed-member
+CFLAGS=$(ARCH_CFLAGS) -Wall -Wextra $(TMPFLGS) -Wno-unused-parameter -Wno-type-limits -Wno-unused-function -fno-stack-protector -fno-omit-frame-pointer -Wno-unused-variable $(CINC) $(MUSLINC) $(OPT) $(SHARED_FLAGS)
 CXXFLAGS=-fno-exceptions -fno-threadsafe-statics -Wno-write-strings $(CFLAGS)
 LDFLAGS=$(ARCH_LDFLAGS) -no-pic
 MUSLCFLAGS=$(CFLAGS) -lc -lgcc -Xlinker -r

src/components/implementation/no_interface/llbooter/llbooter.c

@@ -115,7 +115,7 @@ comps_init(void)
 		assert(id < MAX_NUM_COMPS && id > 0 && name);
 
 		memset(path, 0, INITARGS_MAX_PATHNAME);
-		strncat(path, root, len);
+		strncat(path, root, len + 1);
 		assert(path[len] == '\0');
 		strncat(path, name, INITARGS_MAX_PATHNAME - len);
 		assert(path[INITARGS_MAX_PATHNAME - 1] == '\0'); /* no truncation allowed */

src/components/implementation/tests/slm/Makefile

@@ -0,0 +1,18 @@
+# Required variables used to drive the compilation process. It is OK
+# for many of these to be empty.
+#
+# The set of interfaces that this component exports for use by other
+# components. This is a list of the interface names.
+INTERFACE_EXPORTS =
+# The interfaces this component is dependent on for compilation (this
+# is a list of directory names in interface/)
+INTERFACE_DEPENDENCIES =
+# The library dependencies this component is reliant on for
+# compilation/linking (this is a list of directory names in lib/)
+LIBRARY_DEPENDENCIES = component slm util crt
+# Note: Both the interface and library dependencies should be
+# *minimal*. That is to say that removing a dependency should cause
+# the build to fail. The build system does not validate this
+# minimality; that's on you!
+
+include Makefile.subsubdir

src/components/implementation/tests/slm/doc.md

@@ -0,0 +1,9 @@
+## tests
+
+This is the skeleton interface used by the `mkcomponent.sh` script to aid in the creation of a new component.
+It provides no functionality, and should never be depended on!
+This documentation should be *replaced* in the documentation for a new component.
+
+### Description
+
+### Usage and Assumptions