Slm #421
Open
Slm #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gparmer
commented
Jun 16, 2021
| @@ -0,0 +1,5 @@ | |||
| #ifndef SLM_POLICY_TIMER_H | |||
| #define SLM_POLICY_TIMER_H | |||
|
|
|||
src/components/lib/slm/slm_timer.h
Outdated
| #ifndef SLM_TIMER_H | ||
| #define SLM_TIMER_H | ||
|
|
||
| struct slm_timer_thd { |
| @@ -0,0 +1,9 @@ | |||
| ## tests | |||
|
|
|||
| This is the skeleton interface used by the `mkcomponent.sh` script to aid in the creation of a new component. | |||
There was a problem hiding this comment.
TODO: add documentation here.
| }; | ||
|
|
||
| struct slm_timer_thd * | ||
| slm_thd_timer_policy(struct slm_thd *t) |
There was a problem hiding this comment.
Replace with slm_container.h (see below).
Create a set of macros to enable the scheduler to easily mix and match different policies (edf/fprr/fifo), timers (quantum/oneshot), and memory allocators (static/dynamic).
src/components/lib/slm/doc.md
Outdated
| @@ -0,0 +1,9 @@ | |||
| ## slmin | |||
|
|
|||
| This is the skeleton library used by the `mklib.sh` script to aid in the creation of a new library. | |||
There was a problem hiding this comment.
Add actual documentation.
|
|
||
| /* Thread allocation and indexing API */ | ||
|
|
||
| struct slm_thd *slm_policy_thd_alloc(void); |
There was a problem hiding this comment.
FIXME: make all of this consistent with the above fprr APIs, or remove.
gparmer
commented
Jun 16, 2021
| * `ret`. This assumes that ret == 0 is success, otherwise jump to the | ||
| * label. | ||
| */ | ||
| #define ERR_CHECK(expr, label) \ |
- -no-pic and -no-pie are not valid flags in ld - update needed env deps
- it does not make sense to specify this section manually and set a PHDR (.interp segment) for it, this may cause ld reporting errors because some Alloc type sections might be tried to put into the interp segment by the linker, but we don't have this segment in the final PHDR set.
- fix composer allocating captbl_end using BOOT_CAPTBL_FREE, it is 52 now. This can be used by both i386 and x86_64 - fix pgtbl_lkup_lvl to return/set page table entry flags correctly - fix cos compinfo initialiaztion problem
still needs higher level API/library to call still needs to be tested
- x86_64 ABI requires a 16-byte alignment for fetching data and when calling a function, because some instructions like movabs and sse require data to be 16-byte aligned. Otherwise, it will case a #GP
- .boottext section needs to be aligned to generate correct bootable image - the stack in loader.S needs to be set to .data section, the original .comm will generate a .bss section that could have random address after compiling
- fix the linker script so it can correctly compile a bootable image - add -nmagic flag to $(LD) in the Makefile so $(LD) does not add additional blank information to the bootable image
- enable smp booting into long mode and jump into kmain
…nd validation of composition scripts, and added access to AS representation in the composer's state. The overall goal is to add full initargs support for address spaces, going all the way back to a specification for address spaces from the composition scripts. Steps: 1. DONE: parsing and validation of composition scripts. 2. DONE: add an AS representation to the pass structure of the composer for later pass access. 3. Order ASes by the parent relationship. 4. Assign virtual addresses based on ASes and the parent relation. 5. Synthesize the initargs based on the ASes and addresses. 6. Use the initargs and the AS specification in the booter.
…zation (with containing components, and exclusive AS components) Steps: 1. DONE: parsing and validation of composition scripts. 2. DONE: add an AS representation to the pass structure of the composer for later pass access. 3. -> DONE: Order ASes by the parent relationship. 4. Assign virtual addresses based on ASes and the parent relation. 5. Synthesize the initargs based on the ASes and addresses. 6. Use the initargs and the AS specification in the booter.
1. DONE: parsing and validation of composition scripts.
2. DONE: add an AS representation to the pass structure of the composer for later pass access.
3. DONE: Order ASes by the parent relationship.
4. -> DONE: Assign virtual addresses based on ASes and the parent relation.
This is *not yet integrated into the output*. That's next commit.
5. Synthesize the initargs based on the ASes and addresses.
6. Use the initargs and the AS specification in the booter.
1. DONE: parsing and validation of composition scripts.
2. DONE: add an AS representation to the pass structure of the composer for later pass access.
3. DONE: Order ASes by the parent relationship.
4. DONE: Assign virtual addresses based on ASes and the parent relation.
-> Now integrated into the output!
5. Synthesize the initargs based on the ASes and addresses.
6. Use the initargs and the AS specification in the booter.
…fication. Steps: 1. DONE: parsing and validation of composition scripts. 2. DONE: add an AS representation to the pass structure of the composer for later pass access. 3. DONE: Order ASes by the parent relationship. 4. DONE: Assign virtual addresses based on ASes and the parent relation. 5. -> DONE: Synthesize the initargs based on the ASes and addresses. 6. Use the initargs and the AS specification in the booter.
Steps: 1. DONE: parsing and validation of composition scripts. 2. DONE: add an AS representation to the pass structure of the composer for later pass access. 3. DONE: Order ASes by the parent relationship. 4. DONE: Assign virtual addresses based on ASes and the parent relation. 5. DONE: Synthesize the initargs based on the ASes and addresses. 6. -> DONE: Use the initargs and the AS specification in the booter. Pending: BUG for split ASes that don't properly maintain non-overlapping ASes.
Steps: 1. DONE: parsing and validation of composition scripts. 2. DONE: add an AS representation to the pass structure of the composer for later pass access. 3. DONE: Order ASes by the parent relationship. 4. DONE: Assign virtual addresses based on ASes and the parent relation. 5. DONE: Synthesize the initargs based on the ASes and addresses. 6. DONE: Use the initargs and the AS specification in the booter.
Official NIC/DPDK component support to Composite
Virtual address space specification, assignment, and booting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this Pull Request (PR)
Initial
slmimplementation that is designed toslcodebase by removing hierarchical scheduling,This is a work in progress, and the tests are in
implementation/tests/slm/main.c. Trello encodes many of the next steps, but they include:asnds),Intent for your PR
Choose one (Mandatory):
Reviewers (Mandatory):
(Specify @<github.com username(s)> of the reviewers. Ex: @user1, @user2)
@WenyuanShao @msdx321 @betahxy
Code Quality
As part of this pull request, I've considered the following:
Style:
Code Craftsmanship:
Testing
I've tested the code using the following test programs (provide list here):