Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title on ui.menu #1577

Closed
Rmfjd1978 opened this issue Aug 8, 2022 · 4 comments · Fixed by #1663
Closed

Title on ui.menu #1577

Rmfjd1978 opened this issue Aug 8, 2022 · 4 comments · Fixed by #1663
Assignees
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@Rmfjd1978
Copy link

Rmfjd1978 commented Aug 8, 2022

I have to make a menu inside a header, but my menu needs to have some title

The solution is to have a parameter named label inside de ui.menu that is added to the chevron on a simple menu style.

the alternative solution that i have, is in one of the items of the header is a ui.inline with two items one ui.text and one ui.menu

await create_inline([await create_text(_content="App's"),
                                 await create_menu([await create_command(_name='#sss', _label='sss'),
                                                    await create_command(_name='#rrr', _label='rrr'),
                                                    await create_command(_name='#ttt', _label='ttt')])])

image of the pretended menu:
image

In my alternative the clik event only acts where the chevron icon is clicked, if the menu had a label option the click event will act on the all object of the menu that includes the label and the chevron icon

@Rmfjd1978 Rmfjd1978 added the feature Feature request label Aug 8, 2022
@mturoci mturoci added the ui Related to UI label Aug 9, 2022
@mturoci mturoci added the good first issue Contributions welcome! label Sep 12, 2022
@Pooja444
Copy link
Contributor

Pooja444 commented Oct 5, 2022

@mturoci I would like to work on this issue, can it be assigned to me, please? Will this count towards Hacktoberfest, 2022?
Also, I will need to make changes to this file, right?

@mturoci
Copy link
Collaborator

mturoci commented Oct 5, 2022

Hi @Pooja444 I will assign the issue to you. If you manage to make a valid PR that solves the problem correctly and the PR will get merged, it will count to Hacktoberfest submissions.

Also, I will need to make changes to this file, right?

Yes, this is the starting point, but it's not going to be the only file changed since you need to add a new attribute. See our contribution guidelines for further info.

Note that you are give 4 days before this issue becomes up for grabs again. Good luck!

@Pooja444
Copy link
Contributor

Pooja444 commented Oct 8, 2022

@mturoci I have raised a PR for this issue. I tested it locally and have attached the test screenshots to the PR. Kindly review and let me know if I need to make any changes. Thanks for assigning me this issue!

@mturoci
Copy link
Collaborator

mturoci commented Nov 3, 2022

Closed by #1663

@mturoci mturoci closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants