-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added label parameter to ui.menu #1663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @Pooja444! A few minor changes. Also do not forget to run make generate
after changing the docstrings/attr name. Could you also please add this newly added attribute into our menu.py
example and also document it in menu.md
?
@mturoci thanks for reviewing my PR! I addressed all your review comments, added an example for I also tested it again after the changes - Successful local test - Successful menu.py example run - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will be in wich h2o wave version? |
In the next release - 0.24. Currently available in nightly release. |
Github Issue
Closes #1577
Description
Added a 'label' parameter to the UI component of wave. This label will be displayed beside the arrow for the menu dropdown. It will also be clickable, i.e. the dropdown will open on clicking the arrow as well as the label.
Successful local test -