Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed breaking change in kustomize-controller #619

Closed
h3mmy opened this issue Apr 20, 2022 · 3 comments
Closed

Missed breaking change in kustomize-controller #619

h3mmy opened this issue Apr 20, 2022 · 3 comments
Assignees

Comments

@h3mmy
Copy link
Owner

h3mmy commented Apr 20, 2022

Details

What steps did you take and what happened:

Read release notes and merged #618 before checking known issues. Flux is now failing to reconcile a couple of resources. Here is the related issue

fluxcd/flux2#1522 (comment)

What did you expect to happen:

Smoothness

Anything else you would like to add:

Additional Information:

@h3mmy h3mmy self-assigned this Apr 20, 2022
@h3mmy
Copy link
Owner Author

h3mmy commented Apr 20, 2022

Will utilize kubernetes-sigs/kustomize#4453 strategy which should be included with https://github.com/fluxcd/flux2/releases/tag/v0.29.1

h3mmy added a commit that referenced this issue Apr 20, 2022
@hiddeco
Copy link

hiddeco commented Apr 20, 2022

Heads up that the change to git:: is not strictly required, it works fine with v0.29.1 as also confirmed in tests now: https://github.com/fluxcd/kustomize-controller/blob/v0.24.1/controllers/testdata/remote/kustomization.yaml#L7

@h3mmy
Copy link
Owner Author

h3mmy commented Apr 20, 2022

Thanks! I wasn't sure about that but I can confirm git:: is indeed not required.

@h3mmy h3mmy closed this as completed Apr 20, 2022
h3mmy added a commit that referenced this issue Apr 20, 2022
h3mmy added a commit that referenced this issue Apr 20, 2022
h3mmy added a commit that referenced this issue Apr 20, 2022
h3mmy added a commit that referenced this issue Apr 20, 2022
h3mmy added a commit that referenced this issue Apr 20, 2022
h3mmy added a commit that referenced this issue Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants