Fix pseudo git HTTP urls broken since 59c82659

[sylr]

Simple fix to restore the broken feature of pseudo git HTTP URLS (i.e.: https://github.com/org/repo.git//path/within/repo).

However, I believe the whole resource loading deserves a serious overhaul and each possible way of loading resources should have its own Loader. For example I think the fileLoader should only handle absolute and relative paths, not HTTP URLs like it does now.

Relates to #4030.

Signed-off-by: Sylvain Rabot sylvain@abstraction.fr

[k8s-ci-robot]

Hi @sylr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[thatsmydoing]

Unfortunately, this does not work as it now breaks urls like in your initial PR

resources:
  - https://github.com/fluxcd/helm-controller/releases/download/v0.14.0/helm-controller.crds.yaml

However, I believe the whole resource loading deserves a serious overhaul and each possible way of loading resources should have its own Loader. For example I think the fileLoader should only handle absolute and relative paths, not HTTP URLs like it does now.

I agree but I believe to get there we have to get the kustomize team to decide on what url formats they actually support so that we can add full test cases to ensure that we don't break anything as we move towards it. I was hoping #4030 would trigger a discussion on this but it doesn't seem like there's much interest.

[sylr]

Unfortunately, this does not work as it now breaks urls like in your initial PR

🤦 I wouldn't have guessed that any github url would be considered as a valid git repository.

[sylr]

Ok, I pushed something that should work.

Finally, I think I hate it.

[sylr]

Ok so my take on this is to stop accepting valid HTTP(s) URL as possible Pseudo GIT URL and use the already implemented git:: prefix, e.g.:

• https://github.com/kubernetes-sigs/kustomize/examples/multibases/dev/ -> Error 404
• https://github.com/kubernetes-sigs/kustomize//examples/multibases/dev/ -> Error 404
• https://github.com/kubernetes-sigs/kustomize.git/examples/multibases/dev/ -> Error 404
• https://github.com/kubernetes-sigs/kustomize.git//examples/multibases/dev/ -> Error 404
• git::https://github.com/kubernetes-sigs/kustomize/examples/multibases/dev/ -> OK
• git::https://github.com/kubernetes-sigs/kustomize//examples/multibases/dev/ -> OK
• git::https://github.com/kubernetes-sigs/kustomize.git/examples/multibases/dev/ -> OK
• git::https://github.com/kubernetes-sigs/kustomize.git//examples/multibases/dev/ -> OK

If this is not acceptable, this PR fixes the problem but I don't like it to be honest.

[natasha41575]

Ok so my take on this is to stop accepting valid HTTP(s) URL as possible Pseudo GIT URL and use the already implemented git:: prefix

That is something we can discuss in the future but we are not ready to do a major version bump with backwards breaking changes. Thank you for making this PR, will review when I can.

/ok-to-test

[natasha41575]

However, I believe the whole resource loading deserves a serious overhaul and each possible way of loading resources should have its own Loader. For example I think the fileLoader should only handle absolute and relative paths, not HTTP URLs like it does now.

You can file a tracking issue with this proposal if you'd like. I think your proposal is fine and we can take a look at a PR that does this, but we should first fix the regression and release this week.

For this PR, please add a test to confirm that it works for the URL in #4455.

You can add this test to https://github.com/kubernetes-sigs/kustomize/blob/master/api/krusty/remoteload_test.go, see TestRemoteResource as an example. Let's try to get this in tomorrow, I'll release the patch on Thursday.

[k8s-ci-robot]

@sylr: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[natasha41575]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575, sylr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[natasha41575]

Thanks for the quick fix!

[sylr]

Thanks for the quick fix!

No worries, that was the least I could do.