Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snj-4-feed-categories #31

Merged
merged 11 commits into from
Dec 14, 2021
Merged

snj-4-feed-categories #31

merged 11 commits into from
Dec 14, 2021

Conversation

haIIux
Copy link
Owner

@haIIux haIIux commented Nov 24, 2021

This PR enables the ability to have various categories that users can select to update feeds.
The only thing we will need to determine is a method to properly parse the feeds as some of them are different.

@haIIux haIIux added enhancement New feature or request UI User Interface labels Nov 24, 2021
@0xLeif 0xLeif requested review from 0xLeif and Superbro9 November 24, 2021 02:53

import Foundation
import ComposableArchitecture
import SwiftUI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old Stub

@@ -10,10 +10,11 @@ struct SwiftNewsApp: App {
store: Store(
initialState: RSSFeed(
id: .init(),
title: "Swift by Sundell",
title: "Hacking with Swift",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be able to remove this and just use the FeedURL description.

@haIIux
Copy link
Owner Author

haIIux commented Nov 24, 2021

fixes #4 and #25

@haIIux haIIux merged commit 1b27aba into main Dec 14, 2021
@haIIux haIIux deleted the snj-4-feed-categories branch December 14, 2021 22:24
@haIIux haIIux mentioned this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants