-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snj-4-feed-categories #31
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bc4a45f
file structure
haIIux db1a180
Merge remote-tracking branch 'refs/remotes/origin/main'
haIIux 112b5a2
lazyhgrid setup with dummy data
haIIux 17dded5
updated temp view, updated feed data with new feeds
haIIux 490588b
added description to enum so we can build buttons based of it
haIIux f8d48b3
attempting to extract the issue into it's own view in an effort to ge…
haIIux 0bf077c
temp categories need to figure out how to push to viewStore to then u…
haIIux 0ccf542
added warnings for notes
haIIux 6624ae0
categories
haIIux 2a8bbc9
Categories working.
haIIux cf4ac55
cleaned up non-working feeds
haIIux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
SwiftNews/SwiftNews/RSSCategories/Data/RSSCategoryView.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // | ||
| // RSSCategoryView.swift | ||
| // SwiftNews | ||
| // | ||
| // Created by Rob Maltese on 11/7/21. | ||
| // | ||
|
|
||
| import Foundation | ||
| import ComposableArchitecture | ||
| import SwiftUI | ||
|
|
||
| // MARK: - State | ||
|
|
||
|
|
||
|
|
||
| // MARK: - Actions | ||
|
|
||
|
|
||
| // MARK: -Environment | ||
|
|
||
|
|
||
| // MARK: - Reducer | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| // | ||
| // CategoryTemp.swift | ||
| // SwiftNews | ||
| // | ||
| // Created by Rob Maltese on 11/7/21. | ||
| // | ||
|
|
||
| import SwiftUI | ||
| import ComposableArchitecture | ||
|
|
||
| struct CategoryState: Equatable { | ||
| var feed: FeedURL | ||
| var availableFeeds: [FeedURL] | ||
| } | ||
|
|
||
| enum CategoryActions: Equatable { | ||
| case selectFeed(FeedURL) | ||
| } | ||
|
|
||
| let categoryReducer = Reducer<CategoryState, CategoryActions, Void > { state, action, _ in | ||
| switch action { | ||
| case .selectFeed(let feedURL) : | ||
| state.feed = feedURL | ||
| return .none | ||
| } | ||
| } | ||
|
|
||
| struct CategoriesView: View { | ||
| let store: Store<CategoryState, CategoryActions> | ||
|
|
||
| let rows = [ | ||
| GridItem(.fixed(50)), | ||
| GridItem(.fixed(50)) | ||
| ] | ||
|
|
||
| var body: some View { | ||
| WithViewStore(store) { viewStore in | ||
| ScrollView(.horizontal) { | ||
| LazyHGrid(rows: rows, alignment: .center) { | ||
| ForEach(viewStore.availableFeeds, id: \.self) { item in | ||
| Button { | ||
| viewStore.send(.selectFeed(item)) | ||
| } label: { | ||
| Text(item.description) | ||
| .frame(minWidth: 75, idealWidth: 150, maxWidth: 175, minHeight: 25, idealHeight: 50, maxHeight: 100, alignment: .center) | ||
| .background(viewStore.feed == item ? Color.blue : Color.clear) | ||
| .foregroundColor(viewStore.feed == item ? .white : .blue) | ||
| .cornerRadius(12) | ||
| .overlay(RoundedRectangle(cornerRadius: 12) | ||
| .stroke() | ||
| ) | ||
| } | ||
| } | ||
| } | ||
| .padding(.leading, 5) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| struct CategoryTemp_Previews: PreviewProvider { | ||
| static var previews: some View { | ||
| CategoriesView(store: .init(initialState: CategoryState.init(feed: .sundell, availableFeeds: FeedURL.allCases), reducer: categoryReducer, environment: ())) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old Stub