Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: update installation instructions #327

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

surajssd
Copy link
Contributor

@surajssd surajssd commented Aug 3, 2018

Add instructions to setup GOPATH and place where you can find
the installed binaries.

Fixes: #322 & #298

@surajssd surajssd force-pushed the install-habitat-operator branch 3 times, most recently from bc78933 to 77974dd Compare August 3, 2018 05:41
Copy link
Contributor

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, same with #326 - consider filing another PR from our kinvolk fork, you'll get the tests. But not so important for this PR, because we skip the tests on the PRs with changes only in documentation.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@surajssd surajssd force-pushed the install-habitat-operator branch 3 times, most recently from b97f027 to 29bd1c9 Compare August 13, 2018 05:45
@surajssd
Copy link
Contributor Author

@krnowak changed, PTAL

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
go get -u github.com/habitat-sh/habitat-operator/cmd/habitat-operator

This will put the built binary in `GOBIN`, make sure it is in your `PATH`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't want to talk about GOBIN at all, please just use GOPATH/bin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@surajssd
Copy link
Contributor Author

@krnowak updated :-)

Copy link
Contributor

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also check if you have addressed all the issues from #322 and #298?

README.md Outdated Show resolved Hide resolved
Add instructions to setup GOPATH and place where you can find
the installed binaries.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@jamesc jamesc dismissed krnowak’s stale review January 16, 2019 23:47

Getting new reviewers

@jamesc jamesc requested review from jamesc and removed request for jamesc January 16, 2019 23:47
Copy link

@jamesc jamesc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed install instructions, all look good.

@jamesc jamesc merged commit 2a9b01e into habitat-sh:master Jan 16, 2019
@surajssd surajssd deleted the install-habitat-operator branch January 17, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants