-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: update installation instructions #327
Conversation
bc78933
to
77974dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, same with #326 - consider filing another PR from our kinvolk fork, you'll get the tests. But not so important for this PR, because we skip the tests on the PRs with changes only in documentation.
b97f027
to
29bd1c9
Compare
29bd1c9
to
159d242
Compare
@krnowak changed, PTAL |
README.md
Outdated
go get -u github.com/habitat-sh/habitat-operator/cmd/habitat-operator | ||
|
||
This will put the built binary in `GOBIN`, make sure it is in your `PATH`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't want to talk about GOBIN
at all, please just use GOPATH/bin
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
159d242
to
c167b80
Compare
@krnowak updated :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add instructions to setup GOPATH and place where you can find the installed binaries. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
c167b80
to
fcaa2d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed install instructions, all look good.
Add instructions to setup GOPATH and place where you can find
the installed binaries.
Fixes: #322 & #298