Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish migration of protobuf generation code from rust-protobuf to prost #5949

Closed
christophermaier opened this issue Dec 10, 2018 · 1 comment
Assignees
Labels
Focus:Launcher Related to the Habitat Launcher (core/hab-launcher) component Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Chore Issues for general code and infrastructure maintenance Type:Technical Debt No functional changes; just about cleaning up and reorganizing
Milestone

Comments

@christophermaier
Copy link
Contributor

christophermaier commented Dec 10, 2018

While #5126 and #5179 moved the Supervisor and Butterfly (respectively) over to the prost crate for Protobuf generation, the Launcher and Eventsrv continue to use the old protobuf crate.

In order to reduce unnecessary dependencies and consolidate code, we should finish migrating everything over to prost. (There will also be less work if we remove eventsrv first.)

In the course of doing this, we should also consider some additional clean-ups. In particular, the code that generates the protobuf code is far more complex and intimidating than it needs to be. Additionally, we have discussed further simplifying that code by not checking in generated code, instead having it be generated on-demand at compile time. This also seems to be standard prost practice.

@christophermaier christophermaier added A-supervisor Type:Technical Debt No functional changes; just about cleaning up and reorganizing labels Dec 10, 2018
@christophermaier christophermaier added this to the 1.0 Supervisor milestone Dec 10, 2018
@christophermaier christophermaier self-assigned this Dec 10, 2018
This was referenced Dec 10, 2018
@dmccown dmccown modified the milestones: 1.0 Supervisor, Post 1.0 Dec 18, 2018
@baumanj
Copy link
Contributor

baumanj commented Feb 26, 2019

Resolved by #6105 and #6153

@baumanj baumanj closed this as completed Feb 26, 2019
@christophermaier christophermaier added Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Focus:Launcher Related to the Habitat Launcher (core/hab-launcher) component Type: Chore Issues for general code and infrastructure maintenance and removed A-supervisor labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus:Launcher Related to the Habitat Launcher (core/hab-launcher) component Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Chore Issues for general code and infrastructure maintenance Type:Technical Debt No functional changes; just about cleaning up and reorganizing
Projects
None yet
Development

No branches or pull requests

3 participants