-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cargo.lock #5467
Labels
Epic
Focus:Launcher
Related to the Habitat Launcher (core/hab-launcher) component
Focus: Studio
Related to the Habitat Studio (core/hab-studio) component
Focus:Supervisor
Related to the Habitat Supervisor (core/hab-sup) component
Type:BugFixes
PRs that fix an existing bug
Type: Chore
Issues for general code and infrastructure maintenance
Comments
baumanj
added a commit
that referenced
this issue
Aug 16, 2018
This is step one in #5467 Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
baumanj
added a commit
that referenced
this issue
Aug 20, 2018
This makes the very small necessary fix in components/sup-protocol/src/lib.rs to support the new version. It also includes unrelated changes as the result of running `cargo update` to refresh Cargo.lock to the new `rand` version. See #5467 Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
This was referenced Aug 20, 2018
baumanj
added a commit
that referenced
this issue
Aug 21, 2018
Specifically `rusoto_core`, `rusoto_credential` and `rusoto_ecr`. This makes the very necessary fixes in components/pkg-export-docker/src/lib.rs and adds futures to the appropriate Cargo.toml to support the new version. See #5467 Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
baumanj
added a commit
that referenced
this issue
Aug 24, 2018
Specifically `prost`, `prost-types`, `prost-build` and `prost-derive`. This makes the minor fix in components/butterfly/build.rs to support the new version and updates Cargo.lock. See #5467 Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
I was keeping this around as a tracking issue for all the dependencies we had pinned to a specific version (of which |
christophermaier
added
Type:BugFixes
PRs that fix an existing bug
Focus:Supervisor
Related to the Habitat Supervisor (core/hab-sup) component
Focus:Launcher
Related to the Habitat Launcher (core/hab-launcher) component
and removed
X-fix
labels
Jul 24, 2020
christophermaier
added
Focus: Studio
Related to the Habitat Studio (core/hab-studio) component
Type: Chore
Issues for general code and infrastructure maintenance
and removed
A-studio
labels
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Epic
Focus:Launcher
Related to the Habitat Launcher (core/hab-launcher) component
Focus: Studio
Related to the Habitat Studio (core/hab-studio) component
Focus:Supervisor
Related to the Habitat Supervisor (core/hab-sup) component
Type:BugFixes
PRs that fix an existing bug
Type: Chore
Issues for general code and infrastructure maintenance
Currently
Cargo.lock
is badly out of sync with the dependency versions that would be generated from scratch. Add to this the fact thatcargo update
for a single package is broken and the only option left for accessing new code (which we frequently need to do across our own repositories) is error-prone hand edits to theCargo.lock
file.In order to get
Cargo.lock
to a maintainable state, we must go through the painful process of closing the significant gap between the current dependent package versions and the versions that our variousCargo.toml
files declare (usually*
, which resolves to the newest version). Once we getCargo.lock
into a good state, it can be regularly updated as part of our post-release process and should be relatively painless.To get to that point, we must first close the gap. Based on experiences with similar work for the builder repo, there may be a significant amount of effort and frustration required. In order to avoid large, risky changes, we will attempt to first lock all out-of-sync dependency versions to their current values in
Cargo.lock
, and then gradually relax them while making the necessary code changes to ensure compatibility. This may result in a significant number of commits, so this issue will be used to track all the added version locking and the PRs which will relax them.Dependencies that are version-locked by #5468 (comment), that need to later be relaxed:
rand Relax the version pin for the
rand
crate #5487 Update Cargo.lock, replace mktemp with rand and fix deprecations #5656prost, prost-derive, prost-build, prost-types Relax the version pins for the various
prost
crates #5501 Update sup-protocol protocol generation process #5506uuid Relax the version pin for the
uuid
crate #5492protobuf → prost Generate protobuf code in Supervisor and Launcher package builds #6153, Convert all of the launcher crates to use prost. #6105
rustoto_core, rusoto_credential, rusoto_ecr Relax rusoto version pins #5493
pkg-config, tabwriter, serde and serde-json Remove unnecessary crate version pins, fix typo and add comments for hyper pins #5729
fix warnings Replace deprecated usage of rand crate with mktemp #5562 Fix compile warning #5595 Replace deprecated gen_ascii_chars() with sample_iter(&Alphanumeric) #5655 Tokio deprecation fixes #5727
The text was updated successfully, but these errors were encountered: