Replace deprecated usage of rand crate with mktemp #5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more concise and has the benefit of cleaning up afterwards if there is an error before the temporary file is renamed. Also, since we implemented io:Error -> error:Error::IO, simplify some of the lines that used map_err previously. Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
baumanj
requested review from
chefsalim,
christophermaier,
fnichol,
raskchanky and
reset
as code owners
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
raskchanky
approved these changes
Sep 5, 2018
|
|
chef-ci
pushed a commit
that referenced
this pull request
Sep 5, 2018
Obvious fix; these changes are the result of automation not creative thinking.
baumanj
added a commit
that referenced
this pull request
Sep 10, 2018
This is more concise and has the benefit of cleaning up afterwards if there is an error before the temporary file is renamed. See similar prior work #5562 Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
This was referenced Sep 19, 2018
christophermaier
added
Type:BugFixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #5511 since that one got messy with the intervening changes to Cargo.lock.
This is more concise and has the benefit of cleaning up afterwards if there is
an error before the temporary file is renamed.
Also, since we implemented io:Error -> error:Error::IO, simplify some of the
lines that used map_err previously.