Replace deprecated gen_ascii_chars() with sample_iter(&Alphanumeric) #5655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baumanj
requested review from
christophermaier,
fnichol,
raskchanky and
reset
as code owners
|
Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
This was referenced Sep 19, 2018
Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
christophermaier
force-pushed
the
replace-deprecated-gen_ascii_chars/5467
branch
from
835c5dc
to
402d32e
Compare
chef-ci
pushed a commit
that referenced
this pull request
Sep 24, 2018
Obvious fix; these changes are the result of automation not creative thinking.
christophermaier
added a commit
to habitat-sh/builder
that referenced
this pull request
Sep 28, 2018
See habitat-sh/habitat#5655 Signed-off-by: Christopher Maier <cmaier@chef.io>
cnunciato
pushed a commit
to habitat-sh/builder
that referenced
this pull request
Oct 2, 2018
See habitat-sh/habitat#5655 Signed-off-by: Christopher Maier <cmaier@chef.io>
christophermaier
added
Type:BugFixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should merge after #5656 to minimize Cargo.lock conflicts.
This obviates #5598. Upon further thought, the use case isn't really a temporary file (which should be removed), but generating a temporary name.
I'll be partially reverting #5562 as well and taking this approach.