Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the version pins for the various prost crates #5501

Merged
merged 2 commits into from
Aug 24, 2018

Conversation

baumanj
Copy link
Contributor

@baumanj baumanj commented Aug 24, 2018

Specifically prost, prost-types, prost-build and prost-derive.

This makes the minor fix in components/butterfly/build.rs to support the new version and updates Cargo.lock.

All other changes to rust files are generated code and can be ignored.

See #5467

No internal changes; just the `cargo update` finding new external work.

Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
Specifically `prost`, `prost-types`, `prost-build` and `prost-derive`.

This makes the minor fix in components/butterfly/build.rs to support the new
version and updates Cargo.lock.

See #5467

Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
@baumanj baumanj added the X-fix label Aug 24, 2018
@baumanj baumanj self-assigned this Aug 24, 2018
@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@baumanj baumanj mentioned this pull request Aug 24, 2018
7 tasks
@baumanj baumanj merged commit 5ff2dbe into master Aug 24, 2018
@baumanj baumanj deleted the origin/relax-prost-version-pins/5467 branch August 24, 2018 17:19
christophermaier added a commit that referenced this pull request Aug 25, 2018
Looks like these tweaks got left off #5501 accidentally.

(The new version of Prost automatically derives `Hash` for Enums, and
apparently none of the other types needed it.)

Signed-off-by: Christopher Maier <cmaier@chef.io>
@christophermaier christophermaier added Type:BugFixes PRs that fix an existing bug and removed X-fix labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:BugFixes PRs that fix an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants