Remove eventsrv #5962
Labels
Epic
Focus:Supervisor
Related to the Habitat Supervisor (core/hab-sup) component
Type: Chore
Issues for general code and infrastructure maintenance
Milestone
Comments
|
Yes, please! |
|
There's a command line flag that eventsrv responds to that should be deprecated as well. |
|
Deprecated implies is still works, but generates a warning; I think we should be removing this code entirely. I'd be open to the idea of a (possibly hidden) CLI option that reports that the feature has been removed, but since I really don't think anyone is using it, just deleting it seems like the most appropriate course to me. |
baumanj
added a commit
that referenced
this issue
Jan 7, 2019
- Import locked_env_var in the new style and remove unnecessary macro_use - Add back "extern crate time as time_crate" since the new explicit form: "use ::time" gets reverted to the ambiguous "use time" by rustfmt - Change "use json" to "use crate::json" to resolve ambiguity with macro The change to eventsrv-protocol/src/message/event.rs is generated code which reverts some changes the automatic conversion added. It's built with protobuf rather than prost, so it's not worth fixing since we'll be removing the EventSrv code soon anyway. See #5962 Signed-off-by: Jon Bauman <5906042+baumanj@users.noreply.github.com>
Merged
christophermaier
added
Focus:Supervisor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
It's essentially prototype code that hasn't been touched or used in a long time. Were we to revive the feature, I'm pretty sure we'd want to look at it fresh, rather than using the existing code. I'm pretty sure the build process is broken (and has been for a while), and isn't part of our release process.
If we removed it, we could simplify the Supervisor, and we would also make #5949 easier to implement.
Acceptance Criteria
renamed_and_removed_lintsto clippy'sDENIED_LINTSin Makefile.The text was updated successfully, but these errors were encountered: