Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report]: The selectDynamic for DoricColumn[Row] makes hard to read the errors of missing methods #265

Closed
alfonsorr opened this issue Aug 10, 2022 · 0 comments · Fixed by #269
Closed

[Bug report]: The selectDynamic for DoricColumn[Row] makes hard to read the errors of missing methods #265

alfonsorr opened this issue Aug 10, 2022 · 0 comments · Fixed by #269
Labels
API bug 🐛 Something isn't working spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3

Comments

@alfonsorr
Copy link
Member

Example:

col[String]("foo").methodNotImplemented
Don't throw an error that the methodNotImplemented doesn't exist, instead it tries to invoke the selectDynamic for DoricColumn[Row], and throws an error saying that the doric column is not of Row type.

It should throw an error that the method is not valid.

  • I have checked the current created issues, and it seems there is no other issue like this one:
    • YES

Doric version *

All
@eruizalo eruizalo added the bug 🐛 Something isn't working label Aug 16, 2022
eruizalo added a commit to eruizalo/doric that referenced this issue Aug 18, 2022
@eruizalo
fix: [~] child dynamic accessor only for struct columns (issue hablap…
a9124ae 
…ps#265)
eruizalo added a commit to eruizalo/doric that referenced this issue Aug 18, 2022
@eruizalo
fix: [~] child dynamic accessor only for struct columns (issue hablap…
170ab7e 
…ps#265)
@eruizalo eruizalo mentioned this issue Aug 18, 2022
Merged
eruizalo added a commit to eruizalo/doric that referenced this issue Aug 18, 2022
@eruizalo
fix: [~] child dynamic accessor only for struct columns (issue hablap…
4755181 
…ps#265)
@eruizalo eruizalo added spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_2.4 PR changes to spark 2.4 API spark_3.3 PR changes to spark 3.3 labels Aug 22, 2022
@jserranohidalgo jserranohidalgo mentioned this issue Aug 24, 2022
Closed
eruizalo added a commit to eruizalo/doric that referenced this issue Aug 31, 2022
@eruizalo
fix: [~] child dynamic accessor only for struct columns (issue hablap…
4931b97 
…ps#265)
eruizalo added a commit to eruizalo/doric that referenced this issue Sep 24, 2022
@eruizalo
fix: [~] child dynamic accessor only for struct columns (issue hablap…
01f8275 
…ps#265)
eruizalo added a commit to eruizalo/doric that referenced this issue Feb 3, 2023
@eruizalo
fix: [~] child dynamic accessor only for struct columns (issue hablap…
c781da3 
…ps#265)
alfonsorr pushed a commit that referenced this issue Feb 3, 2023
@eruizalo
fix: [~] child dynamic accessor only for struct columns (issue #265) (#…
1fd8884 
…269)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API bug 🐛 Something isn't working spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
Habla doric
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [~] child dynamic accessor only for struct columns (issue #265) eruizalo/doric
2 participants
@eruizalo @alfonsorr