Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [~] child dynamic accessor only for struct columns (issue #265) #269

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

eruizalo
Copy link
Collaborator

Description

Explained in the issue

Related Issue and dependencies

How Has This Been Tested?

  • This pull request contains appropriate tests?:
    • YES

@eruizalo eruizalo requested a review from a team as a code owner August 18, 2022 10:51
@github-actions github-actions bot added spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3 labels Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #269 (c781da3) into main (a4cd92a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files          60       60           
  Lines        1163     1164    +1     
  Branches       14       19    +5     
=======================================
+ Hits         1133     1134    +1     
  Misses         30       30           
Flag Coverage Δ
spark-2.4.x 94.69% <100.00%> (+0.01%) ⬆️
spark-3.0.x 96.48% <100.00%> (+<0.01%) ⬆️
spark-3.1.x 97.29% <100.00%> (+<0.01%) ⬆️
spark-3.2.x 97.53% <100.00%> (+<0.01%) ⬆️
spark-3.3.x 97.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/main/scala/doric/DoricColumn.scala 66.67% <ø> (ø)
core/src/main/scala/doric/syntax/DStructs.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4cd92a...c781da3. Read the comment docs.

@eruizalo eruizalo added the bug 🐛 Something isn't working label Sep 27, 2022
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

:octocat: This is an auto-generated comment created by:

Actor Triggering actor Sender
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
eruizalo
Triggered by:

Test summary report 📊

Spark version testing
2.4.1 588 passed, 2 skipped
2.4.2 588 passed, 2 skipped
2.4.3 588 passed, 2 skipped
2.4.4 588 passed, 2 skipped
2.4.5 588 passed, 2 skipped
2.4.6 589 passed, 2 skipped
2.4.7 589 passed, 2 skipped
2.4 589 passed, 2 skipped
3.0.0 621 passed, 2 skipped
3.0.1 621 passed, 2 skipped
3.0.2 621 passed, 2 skipped
3.0 621 passed, 2 skipped
3.1.0 649 passed, 2 skipped
3.1.1 649 passed, 2 skipped
3.1.2 649 passed, 2 skipped
3.1 649 passed, 2 skipped
3.2.0 653 passed, 2 skipped
3.2.1 653 passed, 2 skipped
3.2 653 passed, 2 skipped
3.3.0 653 passed, 2 skipped
3.3 653 passed, 2 skipped

@alfonsorr alfonsorr merged commit 1fd8884 into hablapps:main Feb 3, 2023
@eruizalo eruizalo deleted the bugfix/265-selectDynamic branch February 9, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working spark_2.4 PR changes to spark 2.4 spark_3.0 PR changes to spark 3.0 spark_3.1 PR changes to spark 3.1 spark_3.2 PR changes to spark 3.2 spark_3.3 PR changes to spark 3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report]: The selectDynamic for DoricColumn[Row] makes hard to read the errors of missing methods
2 participants