Test/increase coverage #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eruizalo
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 81.87% 91.44% +9.58%
==========================================
Files 39 39
Lines 579 596 +17
Branches 7 10 +3
==========================================
+ Hits 474 545 +71
+ Misses 105 51 -54
Continue to review full report at Codecov.
|
eruizalo
commented
Dec 10, 2021
| @@ -90,6 +98,9 @@ private[sem] trait AggregationOps | |||
| * "age" -> "max" | |||
| * )) | |||
| * }}} | |||
| * @todo this example is not from doric | |||
There was a problem hiding this comment.
@alfonsorr take a look at this
| * @group Aggregation Numeric Type | ||
| * @see [[org.apache.spark.sql.functions.sum(e:* org.apache.spark.sql.functions.sum]] | ||
| */ | ||
| def sum2Long[T: NumericIntegerType](col: DoricColumn[T]): LongColumn = |
There was a problem hiding this comment.
@alfonsorr DYT this name is OK?
eruizalo
force-pushed
the
test/increase_coverage
branch
from
3d9b542
to
8b216dd
Compare
alfonsorr
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.