Merge pull request #896 from ml-evs/close_#864

Assign `__init__` arg to instance attribute to fix sklearn base `__repr__`
hackingmaterials · Dec 17, 2022 · e1b83b3 · e1b83b3
2 parents 93cde56 + 1f33511
commit e1b83b3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/matminer/featurizers/structure/order.py b/matminer/featurizers/structure/order.py
@@ -29,6 +29,7 @@ def __init__(self, desired_features=None):
             desired_features: [str] - choose from "density", "vpa",
                 "packing fraction"
         """
+        self.desired_features = desired_features
         self.features = ["density", "vpa", "packing fraction"] if not desired_features else desired_features
 
     def precheck(self, s: Structure) -> bool:

diff --git a/matminer/featurizers/structure/symmetry.py b/matminer/featurizers/structure/symmetry.py
@@ -32,6 +32,7 @@ class GlobalSymmetryFeatures(BaseFeaturizer):
     all_features = ["spacegroup_num", "crystal_system", "crystal_system_int", "is_centrosymmetric", "n_symmetry_ops"]
 
     def __init__(self, desired_features=None):
+        self.desired_features = desired_features
         self.features = desired_features if desired_features else self.all_features
 
     def featurize(self, s):