Assign __init__
arg to instance attribute to fix sklearn base __repr__
#896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #864.
Simply turns the
desired_features
arg to the__init__
ofDensityFeatures
andGlobalSymmetry
into an instance attribute, which prevents a crash when calling__repr__
for the class (something that happens within featurization progress bars). This is because__repr__
is being inherited from the underlyingsklearn
class that provides introspection into the__init__
arguments of the featurizer.This PR fixes it in the places I have run into personally, but more may be lurking around. One general fix would be to simply define a custom
__repr__
for the basematminer
featurizer to avoid using thesklearn
one.