feat: isolate DefId: faster build times
#703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziskuskiefer
approved these changes
Jun 6, 2024
W95Psp
added a commit
that referenced
this pull request
Jun 12, 2024
… w/o `full` This get rids of the `#[path]` introduced #703 by using the disabling the new `full` feature of `hax-frontend-exporter`.
W95Psp
added a commit
that referenced
this pull request
Jun 12, 2024
… w/o `full` This get rids of the `#[path]` introduced #703 by using the disabling the new `full` feature of `hax-frontend-exporter`.
W95Psp
added a commit
that referenced
this pull request
Jun 13, 2024
… w/o `full` This get rids of the `#[path]` introduced #703 by using the disabling the new `full` feature of `hax-frontend-exporter`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCaml build depends on the binary
hax-engine-names-extract, which, at build-time, depends on the hax frontend.hax-engine-names-extractruns the frontend at build time onhax-engine-names, which itself used to depend on the cratehax-engine-frontend. Running hax however sets specific cfg flags, yielding recompilations.This PR cut the dependency between
hax-engine-namesandhax-engine-frontend.hax-engine-namesneeds only three type definitions fromhax-engine-frontend: this PR isolates those three types in a module, and makeshax-engine-namesdirectly use that module, inlined.