refactor: feature gate all implementations with full
#713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
force-pushed
the
frontend-add-full-feature
branch
from
f8dcefe
to
58646a3
Compare
W95Psp
force-pushed
the
frontend-add-full-feature
branch
5 times, most recently
from
10cb7bb
to
d623ea1
Compare
W95Psp
force-pushed
the
frontend-add-full-feature
branch
from
d623ea1
to
bdfd2a2
Compare
W95Psp
added a commit
to AeneasVerif/charon
that referenced
this pull request
Jun 12, 2024
This dependency is useless, and is blocking for hacspec/hax#713, which removes the crate `hax-frontend-exporter-options`. This commit thus just drops that dependency and cleans up the commented similar dependencies below.
W95Psp
added a commit
to AeneasVerif/charon
that referenced
this pull request
Jun 12, 2024
This dependency is useless, and is blocking for hacspec/hax#713, which removes the crate `hax-frontend-exporter-options`. This commit thus just drops that dependency and cleans up the commented similar dependencies below.
This PR adds a (default) feature `full` for the `hax-frontend-exporter` crate. With this feature disabled, the crate turns into a mostly type-only crate. The crate depends on rustc and drive `sinto` only with `full` enabled.
… w/o `full` This get rids of the `#[path]` introduced #703 by using the disabling the new `full` feature of `hax-frontend-exporter`.
W95Psp
force-pushed
the
frontend-add-full-feature
branch
from
bdfd2a2
to
2493d27
Compare
|
|
||
| [features] | ||
| default = ["full"] | ||
| full = ["dep:tracing", "dep:itertools", "dep:extension-traits", "dep:lazy_static"] |
There was a problem hiding this comment.
What exactly is this feature? Full isn't a great name. Something a little more descriptive would be nice. Adding some comments here to describe what it enables would be good too.
franziskuskiefer
added
the
waiting-on-author
|
Will be subsumed by #743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a (default) feature
fullfor thehax-frontend-exportercrate. With this feature disabled, the crate turns into a mostly type-only crate. The crate depends on rustc and drivesintoonly withfullenabled.This PR also simplifies some the structure of the workspace:
pathtrick introduced by feat: isolateDefId: faster build times #703 in favor of a dependency tohax-frontend-exporterwhere featurefullis offhax-frontend-exporter-options, now it's possible to inline it inhax-frontend-exporterThis PR is particularly useful for #714