fix iframe synchrization; fix #kubeflow/dashboard#65

hahahannes · Jan 7, 2025 · 24d211f · 24d211f
1 parent 78969ee
commit 24d211f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/components/centraldashboard/public/components/iframe-container.js b/components/centraldashboard/public/components/iframe-container.js
@@ -54,7 +54,11 @@ export class IframeContainer extends PolymerElement {
         // Adds a click handler to be able to capture navigation events from
         // the captured iframe and set the page property which notifies
         const iframe = this.$.iframe;
-        iframe.addEventListener('load', () => {
+        iframe.addEventListener('load', (event) => {
+            const nextLocation = event.target.contentWindow.location;
+            const nextIframePage = nextLocation.href.slice(
+                nextLocation.origin.length);
+            this.page = nextIframePage;
             const syncIframePage = () => {
                 const iframeLocation = iframe.contentWindow.location;
                 const newIframePage = iframeLocation.href.slice(

diff --git a/components/centraldashboard/public/components/main-page.js b/components/centraldashboard/public/components/main-page.js
@@ -381,7 +381,6 @@ export class MainPage extends utilitiesMixin(PolymerElement) {
             }
         }
         window.history.replaceState(null, null, l.toString());
-        this.set('routeHash.path', window.location.hash.substr(1));
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up @@
                 }
             }
             window.history.replaceState(null, null, l.toString());
-            this.set('routeHash.path', window.location.hash.substr(1));
         }
         /**
@@ Expand Down @@