Merge pull request #2933 from csachs/hasDarkBackgroundNamedColor

Use computed background style if colorToRgb fails (fixes #2635)
hakimel · Apr 14, 2021 · 444d127 · 444d127
2 parents be110fa + d1f6e6c
commit 444d127
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/js/controllers/backgrounds.js b/js/controllers/backgrounds.js
@@ -192,8 +192,8 @@ export default class Backgrounds {
 		// color, no class will be added
 		let contrastColor = data.backgroundColor;
 
-		// If no bg color was found, check the computed background
-		if( !contrastColor ) {
+		// If no bg color was found, or it cannot be converted by colorToRgb, check the computed background
+		if( !contrastColor || !colorToRgb( contrastColor ) ) {
 			let computedBackgroundStyle = window.getComputedStyle( element );
 			if( computedBackgroundStyle && computedBackgroundStyle.backgroundColor ) {
 				contrastColor = computedBackgroundStyle.backgroundColor;