Use computed background style if colorToRgb fails (fixes #2635) #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. Thanks for the fix! |
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
Use computed background style if colorToRgb fails (fixes hakimel#2635)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
has-dark-backgroundclass is not properly added, if a named color (e.g.black) is used for thedata-background-colorattribute.If the attribute is explicitly set, it will be passed to
colorToRgb()which can only handle explicit rgb notations, not named colors.As a simple workaround, this PR tries the conversion beforehand, and will use the computed styles if it fails.
Alternatively, one could expand
colorToRgb()to support named colors, e.g. by querying the browser via acanvas(c.f. https://stackoverflow.com/a/47355187 ).