Skip to content

Commit

Permalink
pref: improve the structure of ContributorVo (#4645) (#4705)
Browse files Browse the repository at this point in the history
<!--  Thanks for sending a pull request!  Here are some tips for you:
1. 如果这是你的第一次,请阅读我们的贡献指南:<https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md>。
1. If this is your first time, please read our contributor guidelines: <https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md>.
2. 请根据你解决问题的类型为 Pull Request 添加合适的标签。
2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request.
3. 请确保你已经添加并运行了适当的测试。
3. Ensure you have added or ran the appropriate tests for your PR.
-->

#### What type of PR is this?
/kind improvement
/kind api-change
<!--
添加其中一个类别:
Add one of the following kinds:

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind improvement

适当添加其中一个或多个类别(可选):
Optionally add one or more of the following kinds if applicable:

/kind api-change
/kind deprecation
/kind failing-test
/kind flake
/kind regression
-->

#### What this PR does / why we need it:
优化ContributorVo格式,支持更多信息。
#### Which issue(s) this PR fixes:
<!--
PR 合并时自动关闭 issue。
Automatically closes linked issue when PR is merged.

用法:`Fixes #<issue 号>`,或者 `Fixes (粘贴 issue 完整链接)`
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #4645

#### Special notes for your reviewer:
none
#### Does this PR introduce a user-facing change?

<!--
如果当前 Pull Request 的修改不会造成用户侧的任何变更,在 `release-note` 代码块儿中填写 `NONE`。
否则请填写用户侧能够理解的 Release Note。如果当前 Pull Request 包含破坏性更新(Break Change),
Release Note 需要以 `action required` 开头。
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->

```release-note
contributorFinder 支持返回用户元数据、注册信息、用户权限等。
```
  • Loading branch information
AirboZH authored Oct 11, 2023
1 parent 5742a7d commit 767aa53
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import lombok.ToString;
import lombok.Value;
import run.halo.app.core.extension.User;
import run.halo.app.extension.MetadataOperator;

/**
* A value object for {@link run.halo.app.core.extension.User}.
Expand All @@ -14,7 +15,8 @@
@Value
@ToString
@Builder
public class ContributorVo {
public class ContributorVo implements ExtensionVoOperator {

String name;

String displayName;
Expand All @@ -25,6 +27,8 @@ public class ContributorVo {

String permalink;

MetadataOperator metadata;

/**
* Convert {@link User} to {@link ContributorVo}.
*
Expand All @@ -39,6 +43,7 @@ public static ContributorVo from(User user) {
.avatar(user.getSpec().getAvatar())
.bio(user.getSpec().getBio())
.permalink(permalink)
.metadata(user.getMetadata())
.build();
}
}

0 comments on commit 767aa53

Please sign in to comment.