pref: improve the structure of ContributorVo (#4645) #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/improvement
Codecov Report
@@ Coverage Diff @@
## main #4705 +/- ##
============================================
- Coverage 61.59% 61.58% -0.01%
Complexity 2797 2797
============================================
Files 403 403
Lines 14723 14725 +2
Branches 1023 1023
============================================
Hits 9068 9068
- Misses 5163 5165 +2
Partials 492 492
|
guqing
requested changes
Oct 10, 2023
application/src/main/java/run/halo/app/theme/finders/vo/ContributorVo.java
Outdated
Show resolved
Hide resolved
f2c-ci-robot
bot
added
the
approved
|
/milestone 2.11.x |
guqing
reviewed
Oct 11, 2023
application/src/main/java/run/halo/app/theme/finders/vo/ContributorVo.java
Outdated
Show resolved
Hide resolved
ruibaby
changed the title
guqing
approved these changes
Oct 11, 2023
|
Hi @AirboZH，可能也需要更新一下主题开发文档。 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot bot
pushed a commit
to halo-dev/docs
that referenced
this pull request
Oct 11, 2023
/kind documentation link: halo-dev/halo#4705 ```release-note 更新 ContributorVo 格式 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/kind api-change
What this PR does / why we need it:
优化ContributorVo格式，支持更多信息。
Which issue(s) this PR fixes:
Fixes #4645
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?