fix: twice requests in menus page (#4622)

Signed-off-by: Ryan Wang <i@ryanc.cc>
halo-dev · Sep 22, 2023 · b963f3b · b963f3b
1 parent f953201
commit b963f3b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/console/src/modules/interface/menus/Menus.vue b/console/src/modules/interface/menus/Menus.vue
@@ -195,7 +195,7 @@ const handleDelete = async (menuItem: MenuTreeItem) => {
   <div class="m-0 md:m-4">
     <div class="flex flex-col gap-4 sm:flex-row">
       <div class="w-96">
-        <MenuList v-model:selected-menu="selectedMenu" @select="refetch()" />
+        <MenuList v-model:selected-menu="selectedMenu" />
       </div>
       <div class="flex-1">
         <VCard :body-class="['!p-0']">

diff --git a/console/src/modules/interface/menus/components/MenuList.vue b/console/src/modules/interface/menus/components/MenuList.vue
@@ -35,7 +35,6 @@ const props = withDefaults(
 );
 
 const emit = defineEmits<{
-  (event: "select", menu: Menu): void;
   (event: "update:selectedMenu", menu: Menu): void;
 }>();
 
@@ -76,7 +75,6 @@ const {
 const menuQuery = useRouteQuery("menu");
 const handleSelect = (menu: Menu) => {
   emit("update:selectedMenu", menu);
-  emit("select", menu);
   menuQuery.value = menu.metadata.name;
 };