-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: twice requests in menus page #4622
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov Report
@@ Coverage Diff @@
## main #4622 +/- ##
=========================================
Coverage 61.04% 61.04%
Complexity 2566 2566
=========================================
Files 374 374
Lines 13168 13168
Branches 938 938
=========================================
Hits 8039 8039
Misses 4676 4676
Partials 453 453 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang, wzrove The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area console
/kind bug
/milestone 2.10.x
What this PR does / why we need it:
修复菜单管理页面,切换菜单时请求两次菜单项接口的问题。
Which issue(s) this PR fixes:
Fixes #4578
Special notes for your reviewer:
测试切换菜单,观察浏览器控制台是否有两次请求即可。
Does this PR introduce a user-facing change?