Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: twice requests in menus page #4622

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 18, 2023

What type of PR is this?

/area console
/kind bug
/milestone 2.10.x

What this PR does / why we need it:

修复菜单管理页面,切换菜单时请求两次菜单项接口的问题。

Which issue(s) this PR fixes:

Fixes #4578

Special notes for your reviewer:

测试切换菜单,观察浏览器控制台是否有两次请求即可。

Does this PR introduce a user-facing change?

修复 Console 的菜单管理页面,切换菜单时请求两次菜单项接口的问题。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Sep 18, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 18, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 18, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove September 18, 2023 08:30
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #4622 (fa48171) into main (dd55a0f) will not change coverage.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4622   +/-   ##
=========================================
  Coverage     61.04%   61.04%           
  Complexity     2566     2566           
=========================================
  Files           374      374           
  Lines         13168    13168           
  Branches        938      938           
=========================================
  Hits           8039     8039           
  Misses         4676     4676           
  Partials        453      453           

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

image

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang, wzrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang JohnNiang merged commit b963f3b into halo-dev:main Sep 22, 2023
2 checks passed
@ruibaby ruibaby deleted the fix/menu-items-request branch September 22, 2023 09:27
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

控制台点击菜单时发送重复请求
4 participants