Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: twice requests in menus page #4622

Merged
merged 2 commits into from
Sep 22, 2023
Merged

fix: twice requests in menus page #4622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6cece2
fix: twice requests in menus page
ruibaby Sep 18, 2023
fa48171
Merge branch 'main' into fix/menu-items-request
ruibaby Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion console/src/modules/interface/menus/Menus.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ const handleDelete = async (menuItem: MenuTreeItem) => {
<div class="m-0 md:m-4">
<div class="flex flex-col gap-4 sm:flex-row">
<div class="w-96">
<MenuList v-model:selected-menu="selectedMenu" @select="refetch()" />
<MenuList v-model:selected-menu="selectedMenu" />
</div>
<div class="flex-1">
<VCard :body-class="['!p-0']">
Expand Down
2 changes: 0 additions & 2 deletions console/src/modules/interface/menus/components/MenuList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ const props = withDefaults(
);

const emit = defineEmits<{
(event: "select", menu: Menu): void;
(event: "update:selectedMenu", menu: Menu): void;
}>();

Expand Down Expand Up @@ -76,7 +75,6 @@ const {
const menuQuery = useRouteQuery("menu");
const handleSelect = (menu: Menu) => {
emit("update:selectedMenu", menu);
emit("select", menu);
menuQuery.value = menu.metadata.name;
};

Expand Down