Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

刷新页面时控制台页面标题均显示为 Halo #5752

Closed
wan92hen opened this issue Apr 20, 2024 · 2 comments · Fixed by #5794
Closed

刷新页面时控制台页面标题均显示为 Halo #5752

wan92hen opened this issue Apr 20, 2024 · 2 comments · Fixed by #5794
Assignees
@ruibaby
Labels
area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement.
Milestone
2.15.0

Comments

@wan92hen
Copy link
Collaborator

系统信息

使用的哪种方式运行？

Docker

发生了什么？

#5696 中修改了登录页及控制台的页面标题显示内容，但是在刷新页面及页面加载的时候，标题还是会只显示 Halo 字样。建议刷新及页面加载的时候能够显示实际的页面标题，或者显示空标题。

相关日志输出

No response

附加信息

No response
@ruibaby
Copy link
Member

ruibaby commented Apr 20, 2024

/area ui
/kind improvement

可以考虑直接移除掉 Console 的 index.html 中的 title 文本。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. labels Apr 20, 2024
@ruibaby ruibaby added this to the 2.15.x milestone Apr 23, 2024
@ruibaby
Copy link
Member

ruibaby commented Apr 23, 2024

/assign @LIlGG

@ruibaby ruibaby mentioned this issue Apr 25, 2024
Merged
@ruibaby ruibaby assigned ruibaby and unassigned LIlGG Apr 25, 2024
f2c-ci-robot bot pushed a commit that referenced this issue Apr 25, 2024
@ruibaby
refactor: implementation of browser tab title (#5794)
a644c40 
#### What type of PR is this?

/area ui
/kind improvement
/milestone 2.15.x

#### What this PR does / why we need it:

重构 Console 和 UC 的浏览器标题切换。

1. 将代码逻辑封装为统一的 Hook。
2. 移除 index.html 默认的标题，防止加载中的时候显示不正确。

#### Which issue(s) this PR fixes:

Fixes #5752

#### Special notes for your reviewer:

测试各个页面的标题显示正常即可。

#### Does this PR introduce a user-facing change?

```release-note
重构 Console 和 UC 的浏览器标题切换。
```
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging a pull request may close this issue.

refactor: implementation of browser tab title ruibaby/halo
3 participants
@ruibaby @wan92hen @LIlGG