Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implementation of browser tab title #5794

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 25, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.15.x

What this PR does / why we need it:

重构 Console 和 UC 的浏览器标题切换。

  1. 将代码逻辑封装为统一的 Hook。
  2. 移除 index.html 默认的标题,防止加载中的时候显示不正确。

Which issue(s) this PR fixes:

Fixes #5752

Special notes for your reviewer:

测试各个页面的标题显示正常即可。

Does this PR introduce a user-facing change?

重构 Console 和 UC 的浏览器标题切换。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Apr 25, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.x milestone Apr 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing April 25, 2024 03:26
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Apr 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove April 25, 2024 03:26
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.47%. Comparing base (5fdf6c0) to head (39dc4ef).
Report is 134 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5794      +/-   ##
============================================
- Coverage     56.91%   56.47%   -0.44%     
- Complexity     3319     3357      +38     
============================================
  Files           587      604      +17     
  Lines         18968    19790     +822     
  Branches       1401     1362      -39     
============================================
+ Hits          10795    11177     +382     
- Misses         7594     8046     +452     
+ Partials        579      567      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit a644c40 into halo-dev:main Apr 25, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

刷新页面时控制台页面标题均显示为 Halo
3 participants