Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

对于 官方出品的 SEO 工具集 插件，因一个字段超过最长长度，直接全站崩溃问题 #6899

Closed
azwcl opened this issue Oct 18, 2024 · 2 comments · Fixed by #6924
Closed

对于 官方出品的 SEO 工具集 插件，因一个字段超过最长长度，直接全站崩溃问题 #6899

azwcl opened this issue Oct 18, 2024 · 2 comments · Fixed by #6924
Assignees
@guqing
Labels
area/plugin Issues or PRs related to the Plugin Provider kind/bug Categorizes issue or PR as related to a bug.

Comments

@azwcl
Copy link

azwcl commented Oct 18, 2024

系统信息

使用的哪种方式运行？

Docker

发生了什么？

针对官方出品的 SEO 工具集 的插件，其中爬虫配置这里，有字段：保留最近多少条记录，；这个字段没有进行控制长度；一不小心写超了，直接全站都崩溃了；怎么都恢复不了了；解决不掉了；目前解决是在库里面找到了那个配置，删除了，重启之后才可以恢复；
故有些疑问：

  1. 这种插件的崩溃居然可以影响全站的么，那么如果下次找不到插件配置，删除不掉，岂不是全站一直崩溃？
  2. 是否可以提供一个机制？比如说恢复的机制？难道我如果作为小白，找不到数据库了；只能通过备份来恢复了么？那这个期间如果有数据，岂不是丢失了很多数据哈？

希望官方大大可以重视这个问题哈；

复现步骤

Image
这个地方，数值一旦不小心，填超了，超过了int最大值，就直接全站全部崩溃了；一直无法恢复了；

相关日志输出

No response

附加信息

No response
@JohnNiang
Copy link
Member

Hi @azwcl , thank you for reaching out here!

/ping @halo-dev/sig-halo
/kind bug
/area plugin

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. area/plugin Issues or PRs related to the Plugin Provider labels Oct 19, 2024
@guqing
Copy link
Member

guqing commented Oct 22, 2024

/assign

@guqing guqing mentioned this issue Oct 22, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Oct 23, 2024
@guqing
fix: ignore conversion exceptions for plugin configuration to prevent…
17ec34c 
… program errors (#6924)

#### What type of PR is this?
/kind bug
/area plugin
/milestone 2.20.x

#### What this PR does / why we need it:
修复插件配置可能因为缺少校验导致使用时类型转换失败从而影响 Halo 使用的问题

#### Which issue(s) this PR fixes:
Fixes #6899

#### Does this PR introduce a user-facing change?
```release-note
修复插件配置可能因为缺少校验导致使用时类型转换失败从而影响 Halo 使用的问题
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guqing guqing

Labels
area/plugin Issues or PRs related to the Plugin Provider kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ignore conversion exceptions for plugin configuration to prevent program errors guqing/halo
3 participants
@JohnNiang @guqing @azwcl