Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore conversion exceptions for plugin configuration to prevent program errors #6924

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 22, 2024

What type of PR is this?

/kind bug
/area plugin
/milestone 2.20.x

What this PR does / why we need it:

修复插件配置可能因为缺少校验导致使用时类型转换失败从而影响 Halo 使用的问题

Which issue(s) this PR fixes:

Fixes #6899

Does this PR introduce a user-facing change?

修复插件配置可能因为缺少校验导致使用时类型转换失败从而影响 Halo 使用的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Oct 22, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 22, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/plugin Issues or PRs related to the Plugin Provider label Oct 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen October 22, 2024 10:13
Copy link

sonarcloud bot commented Oct 22, 2024

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.22%. Comparing base (eff73dc) to head (20e631d).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
...halo/app/plugin/DefaultReactiveSettingFetcher.java 28.57% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6924      +/-   ##
============================================
+ Coverage     56.99%   57.22%   +0.23%     
- Complexity     3999     4007       +8     
============================================
  Files           714      712       -2     
  Lines         24110    24122      +12     
  Branches       1585     1592       +7     
============================================
+ Hits          13742    13805      +63     
+ Misses         9756     9703      -53     
- Partials        612      614       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 17ec34c into halo-dev:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/plugin Issues or PRs related to the Plugin Provider kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

对于 官方出品的 SEO 工具集 插件,因一个字段超过最长长度,直接全站崩溃问题
3 participants