Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zhTW locale #3672

Merged
merged 5 commits into from
Apr 3, 2023
Merged

add zhTW locale #3672

merged 5 commits into from
Apr 3, 2023

Conversation

den13501
Copy link
Contributor

@den13501 den13501 commented Apr 2, 2023

What type of PR is this?

/kind feature
/area core

What this PR does / why we need it:

Add zhTW locale.

Which issue(s) this PR fixes:

Fixes #3346

Does this PR introduce a user-facing change?

提供繁体中文(TW)翻译

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 2, 2023
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2023

CLA assistant check
All committers have signed the CLA.

@jkjoy
Copy link

jkjoy commented Apr 3, 2023

咋了台湾同胞是看不懂简体字还是咋地

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution!

Hi @den13501 , I left a comment below, please take some time to have a look.

console/src/locales/index.ts Outdated Show resolved Hide resolved
@JohnNiang
Copy link
Member

/kind feature
/area console
/milestone 2.5.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.5.x milestone Apr 3, 2023
@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #3672 (9b15c37) into main (14d7175) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3672      +/-   ##
============================================
- Coverage     60.18%   59.89%   -0.30%     
+ Complexity     2258     2206      -52     
============================================
  Files           341      333       -8     
  Lines         11504    11330     -174     
  Branches        863      833      -30     
============================================
- Hits           6924     6786     -138     
+ Misses         4157     4131      -26     
+ Partials        423      413      -10     

see 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ruibaby
Copy link
Member

ruibaby commented Apr 3, 2023

@den13501 感谢你的贡献,在合并之前,需要先签署一下我们的 CLA:#3672 (comment)

@den13501
Copy link
Contributor Author

den13501 commented Apr 3, 2023

@den13501 感谢你的贡献,在合并之前,需要先签署一下我们的 CLA:#3672 (comment)

多謝提醒,已簽,第一次pr遇到要簽署文件的真有趣🥸

Co-authored-by: John Niang <johnniang@fastmail.com>
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

image

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2023
@wan92hen
Copy link
Collaborator

wan92hen commented Apr 3, 2023

/approve

image

这是个什么插件的。

@ruibaby
Copy link
Member

ruibaby commented Apr 3, 2023

这是个什么插件的。

https://github.com/lokalise/i18n-ally

console/src/locales/index.ts Outdated Show resolved Hide resolved
console/src/locales/index.ts Show resolved Hide resolved
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit a466ee7 into halo-dev:main Apr 3, 2023
@ruibaby ruibaby modified the milestones: 2.5.x, 2.5.0 Apr 18, 2023
f2c-ci-robot bot pushed a commit that referenced this pull request Apr 19, 2023
#### What type of PR is this?

/kind feature
/area console
/milestone 2.5.x

#### What this PR does / why we need it:

为上传组件 Uppy 导入中文繁体的语言包。

#### Which issue(s) this PR fixes:

Ref #3672

#### Does this PR introduce a user-facing change?

```release-note
None
```
f2c-ci-robot bot pushed a commit that referenced this pull request Feb 17, 2024

#### What type of PR is this?
/kind improvement

#### What this PR does / why we need it:
Correct some simplified Chinese characters that were not replaced in the yaml file of traditional Chinese.

#### Which issue(s) this PR fixes:

Fixes #3672

#### Special notes for your reviewer:
I have read the CONTRIBUTING file, but I'm not familiar with PR operations. If there's anything I can do to improve it, please let me know.

> By the way, the [contribution guidelines](https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md) provided in the PR template and README still use `master` as the main branch, which may cause some confusion for new contributors.

#### Does this PR introduce a user-facing change?


```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

可否考慮加入繁體中文的介面
6 participants