-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add zhTW locale #3672
add zhTW locale #3672
Conversation
咋了台湾同胞是看不懂简体字还是咋地 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution!
Hi @den13501 , I left a comment below, please take some time to have a look.
/kind feature |
Codecov Report
@@ Coverage Diff @@
## main #3672 +/- ##
============================================
- Coverage 60.18% 59.89% -0.30%
+ Complexity 2258 2206 -52
============================================
Files 341 333 -8
Lines 11504 11330 -174
Branches 863 833 -30
============================================
- Hits 6924 6786 -138
+ Misses 4157 4131 -26
+ Partials 423 413 -10 see 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@den13501 感谢你的贡献,在合并之前,需要先签署一下我们的 CLA:#3672 (comment) |
多謝提醒,已簽,第一次pr遇到要簽署文件的真有趣🥸 |
Co-authored-by: John Niang <johnniang@fastmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#### What type of PR is this? /kind feature /area console /milestone 2.5.x #### What this PR does / why we need it: 为上传组件 Uppy 导入中文繁体的语言包。 #### Which issue(s) this PR fixes: Ref #3672 #### Does this PR introduce a user-facing change? ```release-note None ```
#### What type of PR is this? /kind improvement #### What this PR does / why we need it: Correct some simplified Chinese characters that were not replaced in the yaml file of traditional Chinese. #### Which issue(s) this PR fixes: Fixes #3672 #### Special notes for your reviewer: I have read the CONTRIBUTING file, but I'm not familiar with PR operations. If there's anything I can do to improve it, please let me know. > By the way, the [contribution guidelines](https://github.com/halo-dev/halo/blob/master/CONTRIBUTING.md) provided in the PR template and README still use `master` as the main branch, which may cause some confusion for new contributors. #### Does this PR introduce a user-facing change? ```release-note NONE ```
What type of PR is this?
/kind feature
/area core
What this PR does / why we need it:
Add zhTW locale.
Which issue(s) this PR fixes:
Fixes #3346
Does this PR introduce a user-facing change?