refactor: complete default values for global settings #4562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/improvement
Codecov Report
@@ Coverage Diff @@
## main #4562 +/- ##
============================================
+ Coverage 61.02% 61.05% +0.03%
- Complexity 2560 2562 +2
============================================
Files 373 373
Lines 13149 13149
Branches 937 937
============================================
+ Hits 8024 8028 +4
+ Misses 4670 4668 -2
+ Partials 455 453 -2 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
/cherry-pick release-2.9 |
|
@guqing: new pull request created: #4573 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
/milestone 2.10.x
What this PR does / why we need it:
补全系统全局设置的默认值
how to test it?
Which issue(s) this PR fixes:
Fixes #4561
Does this PR introduce a user-facing change?