-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-2.9] refactor: complete default values for global settings #4573
[release-2.9] refactor: complete default values for global settings #4573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov Report
@@ Coverage Diff @@
## release-2.9 #4573 +/- ##
=================================================
+ Coverage 61.02% 61.05% +0.03%
- Complexity 2560 2562 +2
=================================================
Files 373 373
Lines 13150 13150
Branches 937 937
=================================================
+ Hits 8025 8029 +4
+ Misses 4670 4668 -2
+ Partials 455 453 -2 |
This is an automated cherry-pick of #4562
/assign guqing