Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.9] refactor: complete default values for global settings #4573

Conversation

halo-dev-bot
Copy link
Collaborator

@halo-dev-bot halo-dev-bot commented Sep 7, 2023

This is an automated cherry-pick of #4562

/assign guqing

补全系统全局设置的默认值,防止首次安装之后部分功能异常。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 7, 2023
@JohnNiang JohnNiang added this to the 2.9.x milestone Sep 7, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #4573 (7293811) into release-2.9 (bfb37f8) will increase coverage by 0.03%.
Report is 1 commits behind head on release-2.9.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release-2.9    #4573      +/-   ##
=================================================
+ Coverage          61.02%   61.05%   +0.03%     
- Complexity          2560     2562       +2     
=================================================
  Files                373      373              
  Lines              13150    13150              
  Branches             937      937              
=================================================
+ Hits                8025     8029       +4     
+ Misses              4670     4668       -2     
+ Partials             455      453       -2     

see 1 file with indirect coverage changes

@f2c-ci-robot f2c-ci-robot bot merged commit 2e5ba47 into halo-dev:release-2.9 Sep 7, 2023
2 checks passed
@JohnNiang JohnNiang modified the milestones: 2.9.x, 2.9.1 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants