Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support configuring notifier for different notification reason types #4680

Merged
merged 15 commits into from
Oct 8, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 7, 2023

What type of PR is this?

/kind feature
/area core
/area console
/milestone 2.10.x

What this PR does / why we need it:

用户支持为不同的通知事件配置通知方式

image

Does this PR introduce a user-facing change?

用户支持为不同的通知事件配置通知方式

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 7, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Oct 7, 2023
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core area/console Issues or PRs related to the Halo Console labels Oct 7, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and minliacom October 7, 2023 08:40
@guqing
Copy link
Member Author

guqing commented Oct 7, 2023

/cc @ruibaby

@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby October 7, 2023 08:40
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #4680 (1c3fd08) into main (815f6b8) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 53.33%.

@@             Coverage Diff              @@
##               main    #4680      +/-   ##
============================================
- Coverage     61.65%   61.58%   -0.07%     
- Complexity     2781     2797      +16     
============================================
  Files           402      403       +1     
  Lines         14602    14722     +120     
  Branches       1017     1023       +6     
============================================
+ Hits           9003     9067      +64     
- Misses         5108     5163      +55     
- Partials        491      492       +1     
Files Coverage Δ
...o/app/notification/UserNotificationPreference.java 87.50% <ø> (ø)
...ication/UserNotificationPreferenceServiceImpl.java 38.46% <0.00%> (-44.88%) ⬇️
.../endpoint/UserNotificationPreferencesEndpoint.java 60.37% <60.37%> (ø)

@guqing guqing changed the title feat: support modify notifier corresponding to reason type [WIP] feat: support modify notifier corresponding to reason type Oct 7, 2023
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2023
@guqing guqing changed the title [WIP] feat: support modify notifier corresponding to reason type feat: support modify notifier corresponding to reason type Oct 8, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2023
@guqing guqing changed the title feat: support modify notifier corresponding to reason type feat: support configuring notifier for different notification reason types Oct 8, 2023
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member

ruibaby commented Oct 8, 2023

/hold

等待 #4688 合并,然后给开关加上加载状态。

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2023
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member

ruibaby commented Oct 8, 2023

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2023
Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

功能符合预期

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 6411cef into halo-dev:main Oct 8, 2023
2 checks passed
@guqing guqing deleted the feature/notification-setting branch October 8, 2023 10:16
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants