-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support configuring notifier for different notification reason types #4680
feat: support configuring notifier for different notification reason types #4680
Conversation
/cc @ruibaby |
Codecov Report
@@ Coverage Diff @@
## main #4680 +/- ##
============================================
- Coverage 61.65% 61.58% -0.07%
- Complexity 2781 2797 +16
============================================
Files 402 403 +1
Lines 14602 14722 +120
Branches 1017 1023 +6
============================================
+ Hits 9003 9067 +64
- Misses 5108 5163 +55
- Partials 491 492 +1
|
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
/hold 等待 #4688 合并,然后给开关加上加载状态。 |
/unhold |
Signed-off-by: Ryan Wang <i@ryanc.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
功能符合预期
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/area console
/milestone 2.10.x
What this PR does / why we need it:
用户支持为不同的通知事件配置通知方式
Does this PR introduce a user-facing change?