-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add loading state for switch component #4688
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov Report
@@ Coverage Diff @@
## main #4688 +/- ##
=========================================
Coverage 61.73% 61.73%
Complexity 2781 2781
=========================================
Files 402 402
Lines 14584 14584
Branches 1011 1011
=========================================
Hits 9003 9003
Misses 5092 5092
Partials 489 489 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/area console
/kind feature
/milestone 2.10.x
What this PR does / why we need it:
VSwitch 组件支持传入 loading 属性以显示加载状态。
此外,此 PR 为插件启动/停止的开关适配了这个特性用于测试。
Which issue(s) this PR fixes:
Fixes #4687
Special notes for your reviewer:
测试插件启动/停止时是否显示加载状态
Does this PR introduce a user-facing change?