-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve the issue of generated titles missing id #4997
Conversation
/cherry-pick release-2.11 |
@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4997 +/- ##
=========================================
Coverage 55.94% 55.94%
Complexity 3034 3034
=========================================
Files 525 525
Lines 17816 17816
Branches 1329 1329
=========================================
Hits 9967 9967
Misses 7300 7300
Partials 549 549 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherry-pick release-2.11 |
@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ruibaby: new pull request created: #5009 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area console
/milestone 2.12.x
What this PR does / why we need it:
在 #4975 中,使用
decorations
重写了 heading,但由于decorations
只会给 nodeview 增加 id,因此会导致 render 后的 html 中不存在 id。默认编辑器 heading 渲染时,自动增加 id。
How to test it?
使用默认编辑器编辑时,增加 Heading。保存后查看主题端对应的 heading 是否存在 id。
Which issue(s) this PR fixes:
Fixes #4994
Does this PR introduce a user-facing change?