Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.11] fix: resolve the issue of generated titles missing id #5009

Conversation

halo-dev-bot
Copy link
Collaborator

This is an automated cherry-pick of #4997

/assign ruibaby

解决渲染后的 Heading 中不存在 id 的问题。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 7, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and wan92hen December 7, 2023 03:42
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
Copy link

f2c-ci-robot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1548b64) 55.94% compared to head (ec805f2) 55.94%.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-2.11    #5009   +/-   ##
===============================================
  Coverage           55.94%   55.94%           
  Complexity           3034     3034           
===============================================
  Files                 525      525           
  Lines               17816    17816           
  Branches             1329     1329           
===============================================
  Hits                 9967     9967           
  Misses               7300     7300           
  Partials              549      549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit 97b5f72 into halo-dev:release-2.11 Dec 7, 2023
4 checks passed
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.2 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants