Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize reply queries using index mechanisms #5497

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Mar 12, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.14.x

What this PR does / why we need it:

使用索引机制优化回复功能的查询以提高查询速度

Resolves #5435

Does this PR introduce a user-facing change?

使用索引机制优化回复功能的查询以提高查询速度

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 12, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 12, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Mar 12, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and lan-yonghui March 12, 2024 03:51
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 56.58%. Comparing base (5fdf6c0) to head (e3d29ca).
Report is 53 commits behind head on main.

Files Patch % Lines
...ava/run/halo/app/metrics/ReplyEventReconciler.java 0.00% 26 Missing ⚠️
.../java/run/halo/app/content/comment/ReplyQuery.java 0.00% 12 Missing ⚠️
...app/core/extension/reconciler/ReplyReconciler.java 0.00% 5 Missing ⚠️
...run/halo/app/content/comment/ReplyServiceImpl.java 0.00% 1 Missing ⚠️
...alo/app/core/extension/endpoint/ReplyEndpoint.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5497      +/-   ##
============================================
- Coverage     56.91%   56.58%   -0.33%     
+ Complexity     3319     3312       -7     
============================================
  Files           587      591       +4     
  Lines         18968    19170     +202     
  Branches       1401     1359      -42     
============================================
+ Hits          10795    10847      +52     
- Misses         7594     7759     +165     
+ Partials        579      564      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing force-pushed the refactor/indexed-reply branch from 77c5bcf to 3e65318 Compare March 12, 2024 10:38
Signed-off-by: Ryan Wang <i@ryanc.cc>
@guqing guqing force-pushed the refactor/indexed-reply branch from 17fe4e8 to 3aa90a6 Compare March 13, 2024 02:53
@guqing guqing force-pushed the refactor/indexed-reply branch from 3aa90a6 to e3d29ca Compare March 13, 2024 03:07
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit e704e09 into halo-dev:main Mar 13, 2024
8 checks passed
@guqing guqing deleted the refactor/indexed-reply branch March 13, 2024 08:44
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关于评论显示的建议
3 participants