Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

关于评论显示的建议 #5435

Closed
GuGuGee opened this issue Mar 4, 2024 · 3 comments · Fixed by #5504, #5497, #5453 or #5505
Closed

关于评论显示的建议 #5435

GuGuGee opened this issue Mar 4, 2024 · 3 comments · Fixed by #5504, #5497, #5453 or #5505
Assignees
@ruibaby @guqing
Labels
kind/improvement Categorizes issue or PR as related to a improvement.
Milestone
2.14.0

Comments

@GuGuGee
Copy link

GuGuGee commented Mar 4, 2024

开发者您好，这是我的系统信息：

对于评论插件，目前在后台，我发现我自己给用户的回复，也会显示一个跳动绿色的小点（个人感觉会误以为是用户发的评论，我还没点击查看）显得有点奇怪。
image-20240304141740502

另外，在文章页面，评论区，作者对用户的评论回复默认是折叠的状态：

image-20240304141800295

需要点击一下"号才能显示回复改条评论的内容：

image-20240304141808743

猜测可能是为了让评论区看起来简洁一下，所以这样设计。

不知道开发者是否可以考虑在博客后台加一个开关，让博客搭建者选择是否折叠评论区（个人觉得展开评论区会更好一些，因为文章中有些讨论，可能对其他的读者也有帮助，默认打开会方便其他用户浏览）

感谢！
@ruibaby
Copy link
Member

ruibaby commented Mar 4, 2024

感谢反馈问题，但这些问题似乎以 Halo 的改动为主，和此插件可能关系不大，我将转移到 halo-dev/halo。

猜测可能是为了让评论区看起来简洁一下，所以这样设计。

其实主流媒体的评论区也有不少是这样设计的，当时这样设计可能还考虑到查询性能问题，但目前应该可以优化。

cc @guqing 是否可以在评论设置中添加一个 展开评论回复 的选项？然后在接口的每一项评论中添加 replies。

@ruibaby ruibaby transferred this issue from halo-dev/plugin-comment-widget Mar 4, 2024
@ruibaby ruibaby added the kind/improvement Categorizes issue or PR as related to a improvement. label Mar 4, 2024
@ruibaby ruibaby added this to the 2.14.x milestone Mar 4, 2024
@guqing
Copy link
Member

guqing commented Mar 6, 2024

感谢反馈问题，但这些问题似乎以 Halo 的改动为主，和此插件可能关系不大，我将转移到 halo-dev/halo。

猜测可能是为了让评论区看起来简洁一下，所以这样设计。

其实主流媒体的评论区也有不少是这样设计的，当时这样设计可能还考虑到查询性能问题，但目前应该可以优化。

cc @guqing 是否可以在评论设置中添加一个 展开评论回复 的选项？然后在接口的每一项评论中添加 replies。

当时这么做是出于性能考虑而作出的取舍，目前已经实现了索引机制可以在查询评论时默认附上一页（10条或5条）回复数据，当读者对某条评论下的回复感兴趣时可以点击加载更多来获取更多条

@ruibaby
Copy link
Member

ruibaby commented Mar 6, 2024

目前已经实现了索引机制可以在查询评论时默认附上一页（10条或5条）回复数据，当读者对某条评论下的回复感兴趣时可以点击加载更多来获取更多条

这里的排序规则我建议按照 点赞量+创建时间 联合起来排序。

This was referenced Mar 13, 2024
Merged
Merged
Merged
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Mar 15, 2024
@guqing
refactor: simplify the code of reconciler for comment and optimize pe…
7c3f8b9 
…rformance (#5504)

#### What type of PR is this?
/kind improvement
/area core
/milestone 2.14.x

#### What this PR does / why we need it:
优化评论控制器的实现逻辑以优化代码和性能

Resolves #5435 

how to test it?
- 测试删除评论时能正确连同回复一起删除
- 测试评论下的最新回复的已读功能是否正确
- 删除/审核评论,观察主题端和Console端分别显示的评论数量是否正确

#### Does this PR introduce a user-facing change?
```release-note
None
```
@guqing guqing reopened this Mar 15, 2024
f2c-ci-robot bot pushed a commit that referenced this issue Mar 16, 2024
@guqing
feat: add support for fetching replies alongside comment list (#5505)
5e073bf 
#### What type of PR is this?
/kind feature
/area core
/milestone 2.14.x
/kind api-change

#### What this PR does / why we need it:
主题端评论列表支持同时获得评论数据

Resolves #5435

#### Does this PR introduce a user-facing change?
```release-note
主题端评论列表支持同时获得评论数据
```
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 17, 2024
@ruibaby ruibaby mentioned this issue Mar 17, 2024
Closed
@adozhao adozhao mentioned this issue Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

@guqing guqing

Labels
kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
2.14.0
3 participants
@ruibaby @guqing @GuGuGee