-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify the code of reconciler for comment and optimize performance #5504
refactor: simplify the code of reconciler for comment and optimize performance #5504
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5504 +/- ##
============================================
- Coverage 56.91% 56.55% -0.36%
+ Complexity 3319 3310 -9
============================================
Files 587 591 +4
Lines 18968 19182 +214
Branches 1401 1353 -48
============================================
+ Hits 10795 10849 +54
- Misses 7594 7774 +180
+ Partials 579 559 -20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/milestone 2.14.x
What this PR does / why we need it:
优化评论控制器的实现逻辑以优化代码和性能
Resolves #5435
how to test it?
Does this PR introduce a user-facing change?