Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify the code of reconciler for comment and optimize performance #5504

Merged

Conversation

guqing
Copy link
Member

@guqing guqing commented Mar 13, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.14.x

What this PR does / why we need it:

优化评论控制器的实现逻辑以优化代码和性能

Resolves #5435

how to test it?

  • 测试删除评论时能正确连同回复一起删除
  • 测试评论下的最新回复的已读功能是否正确
  • 删除/审核评论,观察主题端和Console端分别显示的评论数量是否正确

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Mar 13, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 13, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Mar 13, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and minliacom March 13, 2024 09:07
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 36.78161% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 56.55%. Comparing base (5fdf6c0) to head (5cbd22d).
Report is 61 commits behind head on main.

Files Patch % Lines
...n/halo/app/content/comment/CommentServiceImpl.java 0.00% 15 Missing ⚠️
...run/halo/app/content/comment/ReplyServiceImpl.java 0.00% 15 Missing ⚠️
...p/core/extension/reconciler/CommentReconciler.java 65.71% 10 Missing and 2 partials ⚠️
...ava/run/halo/app/metrics/ReplyEventReconciler.java 0.00% 7 Missing ⚠️
...vent/post/CommentUnreadReplyCountChangedEvent.java 0.00% 4 Missing ⚠️
.../app/core/extension/reconciler/PostReconciler.java 0.00% 1 Missing ⚠️
...ore/extension/reconciler/SinglePageReconciler.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5504      +/-   ##
============================================
- Coverage     56.91%   56.55%   -0.36%     
+ Complexity     3319     3310       -9     
============================================
  Files           587      591       +4     
  Lines         18968    19182     +214     
  Branches       1401     1353      -48     
============================================
+ Hits          10795    10849      +54     
- Misses         7594     7774     +180     
+ Partials        579      559      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
Copy link

f2c-ci-robot bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 7c3f8b9 into halo-dev:main Mar 15, 2024
8 checks passed
@guqing guqing deleted the refactor/simply-comment-reconciler branch March 15, 2024 16:06
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 17, 2024
f2c-ci-robot bot pushed a commit that referenced this pull request Apr 19, 2024
#### What type of PR is this?
/kind bug
/area core
/milestone 2.15.x

#### What this PR does / why we need it:
修复分页遍历数据的查询参数

此问题由 #5504#5656 重构导致,如果数据超过分页限制会导致无法结束的致命问题

#### Does this PR introduce a user-facing change?
```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关于评论显示的建议
3 participants