Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: trigger plugin config updated event at startup #6346

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 18, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.18.x

What this PR does / why we need it:

插件启动时触发一次插件配置更新事件以便进行资源初始化操作

之前配置插件完后重启/升级插件无法监听到事件则不方便初始化资源需要通过再次监听插件启动事件来实现,现在改为插件启动时可以监听到

Does this PR introduce a user-facing change?

插件启动时触发一次插件配置更新事件以便进行资源初始化操作

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 18, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 18, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jul 18, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG July 18, 2024 07:36
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.29%. Comparing base (bc10336) to head (733f1da).
Report is 91 commits behind head on main.

Files Patch % Lines
...halo/app/plugin/DefaultReactiveSettingFetcher.java 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6346      +/-   ##
============================================
+ Coverage     54.51%   58.29%   +3.78%     
- Complexity     3523     3764     +241     
============================================
  Files           646      646              
  Lines         21862    21979     +117     
  Branches       1528     1545      +17     
============================================
+ Hits          11917    12813     +896     
+ Misses         9328     8547     -781     
- Partials        617      619       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 5707f29 into halo-dev:main Jul 29, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 29, 2024
@guqing guqing deleted the refactor/plugin-config branch July 29, 2024 14:15
f2c-ci-robot bot pushed a commit that referenced this pull request Jul 31, 2024
#### What type of PR is this?
/kind bug
/area core
/milestone 2.18.x

#### What this PR does / why we need it:
修复保存系统配置时出现的 NPE 问题

此问题由于 PR #6346 导致
#### Which issue(s) this PR fixes:
Fixes #6416

#### Does this PR introduce a user-facing change?
```release-note
None
```
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants