Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NPE when saving system configuration #6417

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 31, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.18.x

What this PR does / why we need it:

修复保存系统配置时出现的 NPE 问题

此问题由于 PR #6346 导致

Which issue(s) this PR fixes:

Fixes #6416

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Jul 31, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 31, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jul 31, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby July 31, 2024 03:08
Copy link

sonarcloud bot commented Jul 31, 2024

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.33%. Comparing base (bc10336) to head (70a0d3f).
Report is 97 commits behind head on main.

Files Patch % Lines
...halo/app/plugin/DefaultReactiveSettingFetcher.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6417      +/-   ##
============================================
+ Coverage     54.51%   58.33%   +3.82%     
- Complexity     3523     3766     +243     
============================================
  Files           646      646              
  Lines         21862    21986     +124     
  Branches       1528     1546      +18     
============================================
+ Hits          11917    12825     +908     
+ Misses         9328     8539     -789     
- Partials        617      622       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 0110438 into halo-dev:main Jul 31, 2024
8 checks passed
@guqing guqing deleted the fix/6416 branch July 31, 2024 04:12
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.18.0-rc.1版本保存系统配置报错
3 participants