wallet: don't add coinbase txs to the pending list. #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodech
added
bug
nodech
force-pushed
the
wallet-unconfirmed-cb
branch
from
7b8089b to
1b78312
Compare
rithvikvibhu
approved these changes
Oct 26, 2023
test/wallet-test.js
Outdated
| const pendingBefore = await wallet.getPending(); | ||
| assert.strictEqual(pendingBefore.length, 0); | ||
|
|
||
| assert(cbTX.isCoinbase()); |
There was a problem hiding this comment.
nit: can move above pendingBefore I think
nodech
force-pushed
the
wallet-unconfirmed-cb
branch
from
1b78312 to
84ec945
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #791